kobotoolbox / kpi / 21394246222

81%

master: 76%

push

github

refactor(drawer): remove dead code and migrate to TS DEV-1321 DEV-1320 (#6601)

### 🗒️ Checklist

1. [x] run linter locally
2. [x] update developer docs (API, README, inline, etc.), if any
3. [x] for user-facing doc changes create a Zulip thread at `#Support
Docs Updates`, if any
4. [x] draft PR with a title `<type>(<scope>)<!>: <title> DEV-1234`
5. [x] assign yourself, tag PR: at least `Front end` and/or `Back end`
or `workflow`
6. [x] fill in the template below and delete template comments
7. [x] review thyself: read the diff and repro the preview as written
8. [x] open PR & confirm that CI passes & request reviewers, if needed
9. [ ] delete this section before merging

### 📣 Summary

Internal code cleanup around the left Sidebar.

### 💭 Notes

The plan was to migrate to TS first (DEV-1321) and then remove
`searches` usage (DEV-1320), but it turned out that it was easier to do
both at the same time.

Changes here:
- Split into all these smaller components was unnecessary, especially
after seeing how much dead code is in there
- All the mixins turned out not to be needed too, so no need to tsify
them or go around them much
- Used `Icon` component instead of `<i>` with classnames
- Used proper button component for "new" button

### 👀 Preview steps

1. ℹ️ Have:
   - account
   - few projects
   - few library items
2. Go to Account Settings (top right avatar menu)
3. 🟢 Notice that left sidebar with account settings sections loads
properly
4. Go to My Projects
5. 🟢 Notice that left sidebar with Deployed/Draft/Archived projects
loads properly
6. 🟢 Notice that "new" button appears and works
7. Go to My Library
8. 🟢 Notice that left sidebar with "My Library" and "Public Collections"
loads properly
9. 🟢 Notice that "new" button appears and works
10. Click on the "?" button on bottom left
11. 🟢 Notice that Help Bubble popup appears
12. Click on the "<globe>" button
13. 🟢 Notice that our Github page opens in new tab

7235 of 11333 branches covered (63.84%)

27870 of 34250 relevant lines covered (81.37%)

1.6 hits per line