Ouranosinc / xclim / 21044847054

92%

Build Type

push

github

Committed by web-flow

Commit Message

Remove useless noqas, do not import matplotlib (#2307)

### What kind of change does this PR introduce?

* Removes many bare `# noqa` comments sprinkled throughout the codebase.
* Updates the `pylint` config in `pre-commit` to allow for newer
versions of system-installed `pylint` to run without errors.
* `matplotlib` is no longer imported when checking for the presence of
it in the library (import speed up)

### Does this PR introduce a breaking change?

Not really. This technically increases the number of `mypy` warnings,
but those need to eventually be dealt with anyway.

The `matplotlib` check prevents us from needing to import `matplotlib`
on import, so that should save microseconds off of import time; With
enough importing, this will save years. You're welcome.

### Other information:

The initial removal of `noqa` comments was performed with
[yesqa](https://github.com/asottile/yesqa).

Run Details

49 of 56 new or added lines in 19 files covered. (87.5%)

7 existing lines in 1 file now uncovered.

7852 of 8535 relevant lines covered (92.0%)

6.29 hits per line