bitcoindevkit / bdk-cli / 20714655583

8%

push

github

Merge bitcoindevkit/bdk-cli#233: Fix duplicate wallet creation in non-persistent path

<a class=hub.com/bitcoindevkit/bdk-cli/commit/ba5e349ed31c44cd2083ed6d41313cd9f8d00c53">ba5e349ed Fix duplicate wallet creation in non-persistent path (Mshehu5)

Pull request description:

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->
  The non-persistent wallet path (when sqlite/redb features are disabled) was creating the wallet twice: first as immutable to create the blockchain_client, then again as mutable. This caused the blockchain_client to be initialized with the first wallet instance, but then used with the second wallet instance, creating a mismatch.

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:
  * [x] I'm linking the issue being fixed by this PR
  The PR addresses  https://github.com/bitcoindevkit/bdk-cli/issues/232

ACKs for top commit:
  tvpeter:
    ACK ba5e349ed31c44cd2083ed6d41313cd9f8d00c53

Tree-SHA512: 56b7b612322de302e71940fa71d17d01505

172 of 2177 relevant lines covered (7.9%)

0.3 hits per line