bitcoindevkit / bdk-cli / 21153868360

11%

Build Type

push

github

Committed by tvpeter

Commit Message

Merge bitcoindevkit/bdk-cli#203: Add saving wallet config with `bdk-cli wallet config`

ceb93324b doc(wallet-init): update README.md examples (Steve Myers)
be31c1439 feat(wallet-init): impl TryFrom for WalletOpts (Vihiga Tyonum)
7bf098255 feat(wallet-init): add `wallets` command (Vihiga Tyonum)
f3ee4ee4f feat(init-wallet): rename init & add walletopts (Vihiga Tyonum)
f21729b3e feat: add initializing wallet config (Vihiga Tyonum)

Pull request description:

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  This PR adds `bdk-cli wallet config` command to save wallet configuration information to `config.toml` file in the data directory.

  Fixes #192

  ### Notes to the reviewers

  - Reusing the exported `serde` crate from `bdk_wallet` did not offer the `derive` feature
  - Fix out-of-bound error for `shorten` fn

  ## Changelog notice
  - Add wallet subcommand `config` to save wallet configs
  - Add top-level `wallets` command  to show all saved  wallet configs
  <!-- Notice the release manager should include in the release tag message changelog -->

  ### Checklists

  #### Features

  * [x] command to save a wallet config, give wallet name or a default name is used, clap enforces required options; optional -f to override existing config: `wallet [-f] [-w <name>] config <wallet opts>`
  * [x] All other wallet commands require that a config exists, use wallet name or the default is used. Give error if config is missing: `wallet [-w <name>] sync | balance | new_address |` etc...
  * [x] Repl uses the same wallet configs: `repl [-w <name>]`
  * [x] command to list all saved wallet configs: `wallets`
  * [x] throw warnings if using mainnet and saving a private descriptor in a config.

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I f... (continued)

Run Details

99 of 395 new or added lines in 3 files covered. (25.06%)

1 existing line in 1 file now uncovered.

269 of 2510 relevant lines covered (10.72%)

0.3 hits per line