bitcoindevkit / bdk-cli / 20377635666

8%

Build Type

push

github

Committed by tvpeter

Commit Message

Merge bitcoindevkit/bdk-cli#200: feat: add non-persisted Async Payjoin support

c6bce5887 docs: add Payjoin capability to the README (Mehmet Efe Umit)
4cab2fa8f feat: add payjoin receive support (Mehmet Efe Umit)
0112c924a feat: add payjoin send support (Mehmet Efe Umit)
f62287aff refactor: move broadcast to a helper function (Mehmet Efe Umit)
a28076af9 refactor: move sync to a helper function (Mehmet Efe Umit)

Pull request description:

  ### Description

  This change implements the online commands for both sending and receiving a Payjoin. Note that this PR does not implement Payjoin persistence.

  ### Notes to the reviewers

  Tested on my local regtest with rpc  using the OHTTP relays and directories in the [payjoin-cli README](https://github.com/payjoin/rust-payjoin/tree/master/payjoin-cli). Feel free to do the same, and let me know if there are comments, documentation, etc. which should be changed with this. I was not able to find any...

  Here are the sample command you can use to test on regtest:

  **Send**
  ```
  cargo run --features=rpc -- -n regtest wallet -a USERNAME:PASSWORD -w WALLET_NAME -e "DESCRIPTOR" send_payjoin --ohttp_relay "RELAY1" --ohttp_relay "RELAY2" --fee_rate 1 --uri "URI"
  ```
  **Receive**
  ```
  cargo run --features=rpc -- -n regtest wallet -a USERNAME:PASSWORD -w WALLET_NAME -e "DESCRIPTOR" receive_payjoin --max_fee_rate 1000 --directory "https://payjo.in"  --ohttp_relay "RELAY1" --ohttp_relay "RELAY2" --amount AMOUNT
  ```
  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [X] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [] I've added tests for the new feature  <--- There is n... (continued)

Run Details

0 of 857 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

172 of 2177 relevant lines covered (7.9%)

0.3 hits per line