dnsimple / erldns / 20259632707

84%

push

github

Support for Zone Files & Better parallel loading (#291)

This Pull Request introduces two major enhancements to the `erldns` zone loading subsystem:
- The ability to load standard DNS zone files (in addition to the existing JSON format)
- A significant performance improvement via parallel file loading

Key Changes:
1. Standard Zone File Support: the server can now ingest standard RFC-style DNS zone files. Previously, `erldns` was restricted to loading zones formatted strictly as JSON, allowing for easier migration and compatibility with existing DNS workflows (e.g., BIND zone files).
2. Parallel Zone Loading: the parallel loading process has been refactored from a very ad-hoc mechanism to a more organised one, with better supervision trees and GC characteristics. This is particularly beneficial for deployments with a large number of zones, significantly reducing startup and reload times.
    - The gist is that the loader is now divided into two, a dynamic supervisor and a getter. The getter gets all the files, and for each file, tells the dynamic supervisor to start a worker. Workers will then run the entire logic of the file, and upon termination will GC the entire operations at once. As during startup we want to ensure the machine is ready as soon as possible, we want maximise throughput.

A good entrypoint for reviews is the documentation changes for `erldns_zones`.

177 of 208 new or added lines in 8 files covered. (85.1%)

1399 of 1663 relevant lines covered (84.13%)

1254.6 hits per line