orion-ecs / keen-eye / 20249145120

65%

push

github

refactor: Remove unused generic type parameters from query types

QueryBuilder and QueryEnumerator had generic type parameters (T1..T4) that
were phantom types - they were only used in constructors to register types
into QueryDescription, then never used again.

This consolidation:
- Replaces 4 generic QueryEnumerator types with single non-generic QueryEnumerator
- Replaces 4 generic QueryBuilder types with single non-generic QueryBuilder
- Replaces 4 generic IQueryBuilder interfaces with single IQueryBuilder
- Updates World.Query<T>() to create QueryBuilder and call WithWrite<T>()
- Updates ParallelQueryExtensions to extend non-generic QueryBuilder
- Removes ~880 lines of duplicated code

The API remains the same for callers:
  world.Query<Position, Velocity>().With<Active>().Without<Frozen>()

The generic constraints are still enforced at the World.Query<T>() entry point.

1812 of 1964 branches covered (92.26%)

Branch coverage included in aggregate %.

41 of 46 new or added lines in 3 files covered. (89.13%)

9925 of 10828 relevant lines covered (91.66%)

1.45 hits per line