Unleash / unleash / 19566022040

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: invalid metrics should not crash (#11010)

## About the changes
Properly awaits all submitted promises, preventing the node's main
process from seeing rejected & unawaited promises.

What's going on?
- The bulk metrics handler pushes `registerBackendClient` promises into
promises.
- The next step (`clientMetricsEnvBulkSchema.validateAsync`) throws for
invalid metrics (e.g., `appName: null`), so we jump to catch and return
400.
- Because the code never reaches `Promise.all(...)`, the previously
spawned promises are never awaited. Node later detects the rejected
`registerBackendClient` promise as an **unhandled rejection** and
crashes the process. If that promise hadn’t been rejected, there’d be no
crash, but with invalid input, it does reject.
- **Fix:** always await the spawned tasks (using `Promise.allSettled`)
so every rejection is observed, even when validation later throws.

Run Details

7250 of 7301 branches covered (99.3%)

10 of 26 new or added lines in 1 file covered. (38.46%)

12 existing lines in 2 files now uncovered.

69209 of 75904 relevant lines covered (91.18%)

436.31 hits per line