Unleash / unleash / 19536993849

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: handle invalid permissions in role creation (#11003)

The `create` and `update` role methods used to blindly accept any
incoming permissions, but if the permissions don't exist in the
database, then the database would throw, yielding a 500 error to the
user.

To fix this, we can validate that all the permissions exist before we
try to add the incoming permissions.

The http error only manifests in enterprise, but the fix requires
modifying the access service. Therefore, I've added the tests to the
access service too, such that if you break something, then you don't
need to wait for it to propagate to enterprise.

---------

Co-authored-by: Gastón Fournier <gaston@getunleash.io>

Run Details

7254 of 7306 branches covered (99.29%)

30 of 31 new or added lines in 2 files covered. (96.77%)

6 existing lines in 1 file now uncovered.

69214 of 75881 relevant lines covered (91.21%)

443.53 hits per line