#20028
89%

Ran 24 Oct 2025 11:14PM UTC

Jobs 1

Files 621

Run time 1min

Badge

Embed ▾

Committed 24 Oct 2025 11:03PM UTC coverage: 88.606% (-0.005%) from 88.611%

Build # #20028

Build Type

push

github

Committed by

web-flow

Commit Message

Fix a BinderServerTransport crash in the rare shutdown-before-start case (#12440)

The `isShutdown()` clause of `BinderServerTransport#start()` code was completely
untested and did not in fact work.

The problem is that if the listener does in fact arrive via start()
after shutdown, BinderTransport's `shutdownInternal()` has already set
the state to `SHUTDOWN_TERMINATED` (which is not a valid transition from
itself). It has also already scheduled a call to notifyTerminated() and
releaseExecutors(). This causes a duplicate call to
`transportTerminated` and releasing the same executor twice.

This commit changes `start()` to leave changing state and releasing
executors to `shutdownInternal()`'s. `notifyTerminated()` either runs
then (if already started) or from within `start()` (if not yet started)

Fixes #12439.

Run Details

34955 of 39450 relevant lines covered (88.61%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	87.65	0.41%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
4	74.23	-4.12%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20028.1	24 Oct 2025 11:14PM UTC	621	88.61

grpc / grpc-java / #20028
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20028

grpc / grpc-java / #20028 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20028

grpc / grpc-java / #20028
89%

README BADGES
x