#20029
89%

Ran 26 Oct 2025 08:08PM UTC

Jobs 1

Files 621

Run time 1min

Badge

Embed ▾

Committed 24 Oct 2025 11:03PM UTC coverage: 88.563% (-0.05%) from 88.611%

Build # #20029

Build Type

push

github

Committed by

web-flow

Commit Message

Fix a BinderServerTransport crash in the rare shutdown-before-start case (#12440)

The `isShutdown()` clause of `BinderServerTransport#start()` code was completely
untested and did not in fact work.

The problem is that if the listener does in fact arrive via start()
after shutdown, BinderTransport's `shutdownInternal()` has already set
the state to `SHUTDOWN_TERMINATED` (which is not a valid transition from
itself). It has also already scheduled a call to notifyTerminated() and
releaseExecutors(). This causes a duplicate call to
`transportTerminated` and releasing the same executor twice.

This commit changes `start()` to leave changing state and releasing
executors to `shutdownInternal()`'s. `notifyTerminated()` either runs
then (if already started) or from within `start()` (if not yet started)

Fixes #12439.

Run Details

34938 of 39450 relevant lines covered (88.56%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.17	0.14%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
3	93.22	-1.69%	../core/src/main/java/io/grpc/internal/AbstractClientStream.java
4	74.23	-4.12%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
5	69.83	-4.31%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
6	79.03	-4.84%	../servlet/src/main/java/io/grpc/servlet/ServletAdapter.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20029.1	26 Oct 2025 08:08PM UTC	621	88.56

grpc / grpc-java / #20029
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20029

grpc / grpc-java / #20029 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20029

grpc / grpc-java / #20029
89%

README BADGES
x