kobotoolbox / kpi / 17764863374

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(dataCollectors): set correct redis entries DEV-798 (#6228)

### 💭 Notes
Fixes a mistake in how we were manipulating enketo-generated redis
entries for data collectors. When we POST to <enketo>/surveys/all, it
generates a simple string redis entry for the key `or:<url>,<xform_id>`,
NOT a hash at the key `or:<url>` that has a field called `xform_id.` We
were actually creating a new entry with the new longer url hash key
instead of updating the one that enketo creates.


### 👀 Preview steps
This is basically a regression test except using the correct redis keys.
If you've been testing other PRs for this project, it's a good idea to
clean out your redis entries first and start fresh. At least delete any
keys starting with "or:http".

1. Open a django shell and a redis-cli
2. In the django shell, run `set_data_collector_enketo_links('token_a',
['uid_0', 'uid_1'])`
3. 🟢 In redis run `keys "or:http*"`. The result should be empty. 
4. In redis, run `get "or:<kobo_url>/key/token_a,uid_0"` and make note
of the 31-char hash you get back
5. In a browser, navigate to <enketo_url>/x/<31-char hash>
6. 🟢 You should get a response Request to
http://kf.kobo.local:8080/key/token_a/formList?formID=uid_0 failed. This
means it generated the correct request, but we haven't set up
authentication yet so we expect it to fail
7. Repeat steps 3-5 with "uid_1"
8. In the django shell, run
`rename_data_collector_enketo_links('token_a', 'token_b')`
9. Navigate to the same urls you used in enketo earlier (using the 31
char hashes)
10. 🟢 You should get a response Request to
http://kf.kobo.local:8080/key/token_b/formList?formID=uid_0 failed.
(note the changed token)
11. In the django shell, run
`remove_data_collector_enketo_links('token_b', ['uid_1'])`
12. Navigate to the enketo url you used for uid_1
13. 🟢 You should get a response Survey with this ID not found (because
the entry in redis for this token/asset has been removed)
14. In the django shell, run
`remove_data_collector_en... (continued)

Run Details

6887 of 10852 branches covered (63.46%)

45 of 48 new or added lines in 1 file covered. (93.75%)

763 existing lines in 29 files now uncovered.

26646 of 32796 relevant lines covered (81.25%)

1.6 hits per line