kobotoolbox / kpi / 17764845739

81%

master: 76%

push

github

fix(dataCollectors): fix adding assets to groups in admin DEV-798 (#6226)

### 📣 Summary
Fixes a bug that was removing old assets from data collector groups when
new ones were added.

### 💭 Notes
We were using an incorrect list of old assets, which resulted in us
removing the data collector group from the old assets (eg the ones that
weren't being added). We did not call refresh_from_db after removing the
data collector group, so the code did not realize it needed to add the
data collector group back. This PR fixes the initial problem
(accidentally removing the data collector group) so we don't need to
refresh from db to make sure we didn't remove anything.
Adds some tests so the error doesn't happen again :).


### 👀 Preview steps

1. ℹ️ have an admin account, at least 2 projects, and a data collector
group
2. Add one asset to the data collector group and hit `Save and continue
editing`
3. Add another asset to the data collector group and hit `Save and
continue editing`
4. 🔴 [on main] The initial asset has been removed from the group
5. 🟢 [on PR] The initial asset is still in the group along with the one
that was added

6883 of 10848 branches covered (63.45%)

1 of 1 new or added line in 1 file covered. (100.0%)

26624 of 32772 relevant lines covered (81.24%)

1.6 hits per line