babelfish-for-postgresql / babelfish_extensions / 17671290798

74%

BABEL_5_X_DEV: 77%

push

github

Fix rollback to savepoint in TDS TxnMgmtRequest when XID is not assigned to top transaction (#4086)

In TDS TxnMgmtRequest, after we perform rollback , we check if its was rollback
to savepoint or a complete rollback. In case of compelte rollback we will send a
token back to client while incase of rollback to savepoint we do not. The check
for this relied on top transaction XID being valid if the top transaction is still
active meaning we did a rollback to savepoint but postgres only assings the XID
to transaction when it first needs it i.e. lazy assignment. Now for cases where
top transaction is XID less and we do a rollback to savepoint, the check fails to
detect that top transaction is still active and sends a token back to client anyway
leading to client error "This SqlTransaction has completed; it is no longer usable."

As a fix modify the condition to use IsTransactionBlock() instead of XID

Cherry pick of #4083

Task: BABEL-6090

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

1 of 1 new or added line in 1 file covered. (100.0%)

43927 of 59210 relevant lines covered (74.19%)

273479.39 hits per line