babelfish-for-postgresql / babelfish_extensions / 17820546495

74%

BABEL_5_X_DEV: 77%

push

github

Fix permission checks for views in Planner phase for cross-db cases (#4060)

Commit e2d4ef8de86 - "Fix security checks in selectivity estimation functions."
introduced the permission checks on view in the planner phase. In
Babelfish there is permission specific logic which is implemented in
executor_hook to support the query on cross-db views. While implementing
cross-db view query support, We assumed that permission checks always
happens at executor. After mentioned community changes that assumption
got brocken and cross-db view queries throwing errors of insufficient
privileges.

This commit fixes above issue by adding same logic for supporting
cross-db view query to pre-planning phase using pltsql_planner_hook. It
is basically walking through whole query tree and inserts checkAsUser
field for all the view RTE, so that permission check on views always
happens on TSQL login to support cross-db usecases.

Issues Resolved: BABEL-6035
Signed-off-by: Harsh Lunagariya <lunharsh@amazon.com>

cr: https://code.amazon.com/reviews/CR-216259370

24 of 24 new or added lines in 1 file covered. (100.0%)

43951 of 59234 relevant lines covered (74.2%)

275757.53 hits per line