babelfish-for-postgresql / babelfish_extensions / 17639377792

74%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fixed error when parallel worker tries to access rel with oid > INT32_MAX (#4065) (#4078)

As part of the commit 6da7ff0, we introduced logic to skip permission checking of Babelfish temp table on Parallel
workers. But logic will run into an error if Oid is greated than INT32_MAX because Bitmapset was used to communicate
Oids from leader node to parallel worker. This Bitmapset can only work with signed integer meaning if Oid value is
greater than INT32_MAX then it will be rounded off to negative value in signed integer and Bitmapset will throw an error
that it can't handle negative values.

In order to fix this overflow issue, we create one more bitmapset especially for Oid > INT32_MAX and communicate it
with parallel worker. Construction of bitmapset now would look like this,

if relid <= INT32_MAX
    add relid to temp_relids
else
    add (relid - INT32_MAX - 1) to temp_relids_beyond_int32

Task: BABEL-6079
Signed-off-by: Dipesh Dhameliya <dddhamel@amazon.com>

Run Details

15 of 19 new or added lines in 1 file covered. (78.95%)

159 existing lines in 1 file now uncovered.

43927 of 59210 relevant lines covered (74.19%)

274298.85 hits per line