kobotoolbox / kpi / 17330937152

81%

master: 76%

push

github

feat(instanceHistory): Celery task to clean instance history records DEV-753 (#6165)

### 📣 Summary
InstanceHistory objects are kept for an amount of days given by the
constance parameter SUBMISSION_HISTORY_GRACE_PERIOD. After this period
has passed, the records that have no associated instance (xform_instance
= NULL) are deleted by a celery task that runs weekly.

### 👀 Preview steps
This is covered with unit tests. However, to test you could:

1. Have a project with submissions
2. Delete some submissions 
3. Configure the constance parameter SUBMISSION_HISTORY_GRACE_PERIOD to
0 days.
4. Get a shell (`./manage.py shell_plus`, via docker exec bash) and
inspect the InstanceHistory objects
```
InstanceHistory.objects.filter(xform_instance__isnull=True).count()
```
5. Manually call the task, from the shell:
```
from kobo.apps.openrosa.apps.logger.tasks import delete_expired_instance_history_records

delete_expired_instance_history_records()
```
6. Inspect again the count
`InstanceHistory.objects.filter(xform_instance__isnull=True).count()`

6902 of 10897 branches covered (63.34%)

15 of 15 new or added lines in 1 file covered. (100.0%)

26625 of 32833 relevant lines covered (81.09%)

1.6 hits per line