agama-project / agama / 17230300669

54%

master: 75%

push

github

Adjustments to iSCSI activation (#2678)

## Problem

iBFT is a way to automagically configure iSCSI. No user intervention
should be needed in the installer if iBFT is properly configured.

But iBFT was not being properly initialized by Agama during interactive
installation. Several attempts going back and forward in the UI were
needed to make the whole thing work.

What is worse, if the iBFT-configured devices are part of a multipath
setup (something quite common in enterprise deployments), the multipath
was not automatically detected and some more extra manual steps
(re-probing and so on) were needed.

## Solution

This fixes the problem by:

- Making sure iBFT activation works as expected at an early stage of the
installer execution.
- Automatic activation of multipath happens only when the iBFT devices
are finally ready (with a timeout of 20 seconds in case something goes
wrong).

## Testing

- Tested manually by David Bond (see
[bsc#1247711](https://bugzilla.suse.com/show_bug.cgi?id=1247711))

2224 of 3989 branches covered (55.75%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

25278 of 38796 relevant lines covered (65.16%)

50.28 hits per line