umputun / cronn / 17215620939

75%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resolve web parser reuse and SQLite locking issues (#44)

* fix: resolve web parser reuse and SQLite locking issues

Two critical issues fixed:

1. Web UI parser reuse:
   - Web server was creating new crontab parsers on every sync instead of reusing the centralized parser from main
   - Introduced JobsProvider interface in web package (consumer-side pattern)
   - Web server now accepts parser dependency via constructor
   - Prevents resource waste and ensures consistent parser behavior

2. SQLite database locking:
   - Fixed "database is locked (SQLITE_BUSY)" errors under concurrent access
   - Added RWMutex to SQLiteStore for serialized database operations
   - Protected all DB operations (LoadJobs, SaveJobs, RecordExecution, Close)
   - Added PRAGMA busy_timeout=5000 for additional resilience

Changes:
- Added JobsProvider interface to web package with proper documentation
- Modified web.Server to use injected JobsProvider instead of creating parsers
- Added mutex-based concurrency control to SQLite operations
- Enhanced error messages with more context
- Added comprehensive test coverage for error scenarios
- Updated all tests to provide JobsProvider dependency

* refactor: extract pragma execution helper to reduce code duplication

As suggested in PR review, extracted the duplicate error handling logic
for PRAGMA execution into a helper closure within NewSQLiteStore.
This makes the code cleaner and more maintainable.

Run Details

37 of 49 new or added lines in 3 files covered. (75.51%)

3 existing lines in 2 files now uncovered.

1921 of 2643 relevant lines covered (72.68%)

23.72 hits per line