umputun / cronn / 17202940472

75%

Build Type

push

github

Committed by web-flow

Commit Message

feat(web): add job filter by status and refactor template rendering (#43)

* feat(web): add job filter by status and refactor template rendering

This commit introduces two major improvements:

1. Job Filtering Feature:
   - Add filter by status (all/running/success/failed)
   - Cycle through filter modes via UI button
   - Persist filter preference in cookies
   - Add visual indicators (colored dots) for active filters
   - Comprehensive test coverage for filter functionality

2. Template Rendering Refactoring:
   - Apply IsOOB pattern to eliminate HTML generation in Go code
   - Replace brittle string manipulation with template-based OOB handling
   - Extract complex handlers into smaller, focused functions
   - Create reusable templates for sort-button, filter-button, and stats-updates
   - Eliminate template duplication between base.html and partials

The refactoring addresses code review feedback by:
- Removing fmt.Fprintf HTML generation
- Following DRY principle for templates
- Improving maintainability and testability
- Creating consistent patterns across all handlers

All tests pass with 89.7% coverage.

* refactor(web): use stats-updates template in renderFilteredJobs

- Replace last fmt.Fprintf with template-based rendering
- Add test for stats template error case to improve coverage
- Coverage increased from 89.5% to 90.2%
- Achieve complete HTML template separation from Go code

Run Details

196 of 283 new or added lines in 3 files covered. (69.26%)

2 existing lines in 1 file now uncovered.

1899 of 2616 relevant lines covered (72.59%)

24.88 hits per line