tari-project / tari / 17064915963
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 820
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 54.492% (-0.02%) from 54.51%
17064915963

push

github

web-flow 
feat: add seed peer exclusion to liveness if other peers are available (#7418)

Description
---
Added seed exclusion to the liveness service. First, try to select
connections that exclude seed nodes - if none exist, try including seed
peers. This will encourage the network to prioritise syncing from other
nodes and not overburden the seed peers.

Closes #7328.

Motivation and Context
---
See #7328.

How Has This Been Tested?
---
System-level testing.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Liveness pings now prioritize non-seed peers, reducing unnecessary
traffic to seed nodes.
* Automatic fallback to include seed peers when no suitable non-seed
peers are available, improving connectivity resilience.
* Enhanced logging clarifies when seed peers are excluded or used as a
fallback during ping rounds.
* Monitored peers are consistently included in ping targets to maintain
visibility of key connections.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: SW van Heerden <swvheerden@gmail.com>

10 of 35 new or added lines in 1 file covered. (28.57%)

25 existing lines in 5 files now uncovered.

76707 of 140768 relevant lines covered (54.49%)

193673.94 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
25
73.29
 -2.17% base_layer/p2p/src/services/liveness/service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.89
 -0.17% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
73.29
 -2.17% base_layer/p2p/src/services/liveness/service.rs
2
62.35
 -0.27% comms/dht/src/connectivity/mod.rs
4
59.61
 -1.97% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
17
54.46
 -1.61% comms/core/src/connectivity/manager.rs
Jobs
ID Job ID Ran Files Coverage
1 17064915963.1 820
54.49
 GitHub Action Run
Source Files on build 17064915963