tari-project / tari / 17035877433

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: allow network discovery to exit Waiting state on Ready event (#7417)

Description
This PR fixes an issue where the DHT network discovery state machine
would become stuck in the Waiting state after a DiscoveryComplete event.
Previously, when Waiting::next_event() returned a Ready event, there was
no matching transition arm for (State::Waiting, StateEvent::Ready),
causing the event to be ignored and the state to remain Waiting
indefinitely.

This change adds a transition for (State::Waiting(_), StateEvent::Ready)
to move the state machine to State::Ready(DiscoveryReady::new(...)),
mirroring the existing behavior for (State::OnConnect,
StateEvent::Ready).

Motivation and Context
this issue: https://github.com/tari-project/tari/issues/7381

How Has This Been Tested?
I ran it and I saw the logs and it wasn't stuck in Waiting anymore

What process can a PR reviewer use to test or verify this change?
Start a base node in a low-peer environment so that discovery quickly
completes with 0 peers found.
Check logs after a DiscoveryComplete event

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
[x]

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Exposes live liveness-check results via a new public accessor so tools
can observe node health in real time.
* Configuration now supports serialization/deserialization for easier
export/import of pulse settings.

* **Bug Fixes / Impr... (continued)

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

9 existing lines in 6 files now uncovered.

76718 of 140740 relevant lines covered (54.51%)

193733.67 hits per line