• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 17035877433
62%

Build:
DEFAULT BRANCH: development
Ran 18 Aug 2025 10:24AM UTC
Jobs 1
Files 820
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Aug 2025 08:55AM UTC coverage: 54.51% (+0.02%) from 54.49%
17035877433

push

github

web-flow
fix: allow network discovery to exit Waiting state on Ready event (#7417)

Description
This PR fixes an issue where the DHT network discovery state machine
would become stuck in the Waiting state after a DiscoveryComplete event.
Previously, when Waiting::next_event() returned a Ready event, there was
no matching transition arm for (State::Waiting, StateEvent::Ready),
causing the event to be ignored and the state to remain Waiting
indefinitely.

This change adds a transition for (State::Waiting(_), StateEvent::Ready)
to move the state machine to State::Ready(DiscoveryReady::new(...)),
mirroring the existing behavior for (State::OnConnect,
StateEvent::Ready).

Motivation and Context
this issue: https://github.com/tari-project/tari/issues/7381

How Has This Been Tested?
I ran it and I saw the logs and it wasn't stuck in Waiting anymore

What process can a PR reviewer use to test or verify this change?
Start a base node in a low-peer environment so that discovery quickly
completes with 0 peers found.
Check logs after a DiscoveryComplete event

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
[x]

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Exposes live liveness-check results via a new public accessor so tools
can observe node health in real time.
* Configuration now supports serialization/deserialization for easier
export/import of pulse settings.

* **Bug Fixes / Impr... (continued)

0 of 1 new or added line in 1 file covered. (0.0%)

9 existing lines in 6 files now uncovered.

76718 of 140740 relevant lines covered (54.51%)

193733.67 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
32.18
-0.11% comms/dht/src/network_discovery/state_machine.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
50.48
-0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
90.05
-0.25% comms/core/src/multiplexing/yamux.rs
1
81.3
-0.19% comms/core/src/noise/socket.rs
2
56.07
0.54% comms/core/src/connectivity/manager.rs
2
81.2
-0.3% comms/core/src/protocol/rpc/client/mod.rs
2
62.62
2.4% comms/dht/src/connectivity/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 17035877433.1 18 Aug 2025 10:24AM UTC 820
54.51
GitHub Action Run
Source Files on build 17035877433
  • Tree
  • List 820
  • Changed 10
  • Source Changed 1
  • Coverage Changed 10
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #17035877433
  • 336dc2a9 on github
  • Prev Build on development (#17033178607)
  • Next Build on development (#17064915963)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc