agama-project / agama / 16806093896

83%

push

github

fix(sotware): avoid auto retry questions (#2644)

## Problem

Questions have 2 modes (or policies, or strategies): interactive
(*user*) and non-interactive (*auto*):

* *interactive* mode: the question is automatically answered using the
provided answer (config file) or the question has to be explicitly
answered by clients.
* *non-interactive* mode: the question is automatically answered either
using the provided answer (config file) or using the default answer
(defined by the client at the time of asking the question).

Problem: some questions use *retry* as default answer, which ends up in
an infinite loop (there is no max number of attempts).

https://bugzilla.suse.com/show_bug.cgi?id=1247436

## Solution

It was decided to go with a simple solution in order to provide as
minimal changes as possible for GMC. In the future we will improve the
strategies for anwering questions.

For the time being, the default answer was simply removed from questions
using "retry" as default. This means that in *non-interactive* mode
those questions will stay (they are not auto-anwered).

If you want to avoid that questions and proceed with the installation,
then an answer has to be provided in the config file:

~~~json
"questions": {
  "policy": "auto",
    "answers": [
{ "class": "software.package_error.provide_error", "answer": "continue"
}
    ]
}
~~~

2170 of 3917 branches covered (55.4%)

Branch coverage included in aggregate %.

24984 of 38434 relevant lines covered (65.0%)

49.39 hits per line