agama-project / agama / 16805692514

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat(web): improve layout and accuracy of wired connection details (#2639)

This PR introduces several enhancements to the wired connection details
view, aiming to improve both the accuracy of the shown data and the
usability of the layout, especially in cases where multiple devices
share a connection.

To achieve this, the following actions were taken:

  
*   **Fixed connection settings display**  
The details page now shows the actual connection settings, rather than
using those from the first connected device. This drop the mismatch
between the details view and the corresponding connection form.

*   **Added "Binding Settings" section**  
To clearly displays whether the connection is bound to a specific device
and how (by MAC address or device name), rather than just showing
information for the first device using it.
    
*   **Added support for multiple devices**  
When multiple devices share a connection, users can switch between them
using a tabbed section, making it easier to view and compare individual
device details.
    
*   **Reorganized layout for clarity**  
The layout has been adjusted to better group related information and
improve overall readability.

<details>
  <summary>Click to show/hide some screenshots</summary>

  ---

_Before changes_

<img width="2560" height="1536" alt="localhost_8080_ (25)"
src="https://github.com/user-attachments/assets/95a6be8f-c71d-4a05-a7ed-62b77388b262"
/>

---

**NOTE: below screenshots might be slightly outdated due to suggestions
from code review. They will be updated only if the final result changes
noticeable**

_After changes, with only one device using the connection_

<img width="2560" height="1536" alt="localhost_8080_ (30)"
src="https://github.com/user-attachments/assets/b0065bf0-51d7-43ee-9157-1ef755b0fd54"
/>

---

_After changes, with more than one device sharing the connection_

<img width="2560" height="1536" alt="localhost_8080_ (29)"
src="https://github.com/user-attachments/assets/2aaf... (continued)

Run Details

2170 of 3917 branches covered (55.4%)

Branch coverage included in aggregate %.

43 of 44 new or added lines in 3 files covered. (97.73%)

32 existing lines in 4 files now uncovered.

24984 of 38434 relevant lines covered (65.0%)

49.39 hits per line