shinghim
/
rust-bitcoin
/
16403933810
84%
|
Ran
|
Jobs
1
|
Files
130
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 83.564% (-0.005%) from 83.569%
push
github
apoelstraMerge rust-bitcoin/rust-bitcoin#4639: feat(p2p): create `NetworkExt` trait for default P2P port and `Magic` values <a class=hub.com/shinghim/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/shinghim/rust-bitcoin/commit/eba12041cbeba1de3c71fdc83186dfb112dcae5b">eba12041c feat(p2p): create `NetworkExt` trait for default P2P port and network `Magic` values (Luis Schwab) Pull request description: Closes #4632. ~~Depends on #4640.~~ This PR introduces the `NetworkExt` trait that extends `Network` with getters for default P2P port and network `Magic` bytes. ## Changelog - Create `NetworkExt` trait. - Implement `default_p2p_port` for `Network`. - Implement `default_network_magic` for `Network`. ACKs for top commit: tcharding: ACK eba12041cbeba1de3c71fdc83186dfb112dcae5b apoelstra: ACK eba12041cbeba1de3c71fdc83186dfb112dcae5b; successfully ran local tests Tree-SHA512: 83e05981b8aedc179c475ef83b073a30fb3
41 of 43 new or added lines in 1 file covered. (95.35%)
261 existing lines in 20 files now uncovered.21379 of 25584 relevant lines covered (83.56%)
15242.85 hits per line
New Missed Lines in Diff
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 2 |
95.35 |
p2p/src/network_ext.rs |
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
89.47 |
0.0% | bitcoin/src/lib.rs |
| 1 |
94.44 |
9.44% | primitives/src/pow.rs |
| 1 |
98.46 |
-1.54% | primitives/src/script/owned.rs |
| 1 |
80.42 |
-0.7% | units/src/amount/signed.rs |
| 1 |
87.79 |
-0.58% | units/src/amount/unsigned.rs |
| 3 |
86.67 |
1.42% | primitives/src/sequence.rs |
| 3 |
64.41 |
0.54% | units/src/result.rs |
| 5 |
78.26 |
-21.74% | internals/src/macros.rs |
| 5 |
90.0 |
-1.53% | primitives/src/script/borrowed.rs |
| 6 |
98.76 |
-0.04% | units/src/amount/tests.rs |
| 8 |
77.55 |
-12.24% | units/src/amount/result.rs |
| 15 |
89.08 |
-0.37% | units/src/weight.rs |
| 16 |
89.83 |
-0.14% | units/src/amount/mod.rs |
| 17 |
89.51 |
-1.82% | units/src/amount/serde.rs |
| 20 |
92.93 |
-0.03% | primitives/src/script/mod.rs |
| 23 |
93.29 |
0.01% | bitcoin/src/blockdata/transaction.rs |
| 26 |
92.15 |
0.11% | p2p/src/message.rs |
| 26 |
87.66 |
-1.41% | primitives/src/locktime/relative.rs |
| 29 |
79.14 |
0.0% | bitcoin/src/network/mod.rs |
| 54 |
88.02 |
3.4% | bitcoin/src/blockdata/block.rs |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 16403933810.1 | 130 |
83.56 |
GitHub Action Run |
