shinghim / rust-bitcoin / 16403933810 / 1

84%

master: 84%

push

github

Merge rust-bitcoin/rust-bitcoin#4639: feat(p2p): create `NetworkExt` trait for default P2P port and `Magic` values

<a class=hub.com/shinghim/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/shinghim/rust-bitcoin/commit/eba12041cbeba1de3c71fdc83186dfb112dcae5b">eba12041c feat(p2p): create `NetworkExt` trait for default P2P port and network `Magic` values (Luis Schwab)

Pull request description:

  Closes #4632.
  ~~Depends on #4640.~~
  
  This PR introduces the `NetworkExt` trait that extends `Network` with getters for default P2P port and network `Magic` bytes.
  
  ## Changelog
  - Create `NetworkExt` trait.
  - Implement `default_p2p_port` for `Network`.
  - Implement `default_network_magic` for `Network`.


ACKs for top commit:
  tcharding:
    ACK eba12041cbeba1de3c71fdc83186dfb112dcae5b
  apoelstra:
    ACK eba12041cbeba1de3c71fdc83186dfb112dcae5b; successfully ran local tests


Tree-SHA512: 83e05981b8aedc179c475ef83b073a30fb3

21379 of 25584 relevant lines covered (83.56%)

15242.85 hits per line