shinghim / rust-bitcoin / 16132836379
84%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 129
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.569% (-1.1%) from 84.643%
16132836379

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4668: Inline `script_pubkey` extension traits

<a class=hub.com/shinghim/rust-bitcoin/commit/25e1d8d23d6c767f7fee00cba2bd6d263d8f93e1">25e1d8d23<a href="https://github.com/shinghim/rust-bitcoin/commit/f7274a57c36d0b8d8cc528426e269c27d496bd5f"> Inline script_pubkey ScriptBuf extension trait (Tobin C. Harding)
<a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/afd36079e559f4222dd6f56b27fc25c0976eb54f">afd36079e</a><a href="https://github.com/shinghim/rust-bitcoin/commit/f7274a57c36d0b8d8cc528426e269c27d496bd5f"> Inline script_pubkey Script extension traits (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/f8823f5c6a596238ff5f7fa30610737291fe0e5e">f8823f5c6</a> Remove BuilderExt trait (Tobin C. Harding)

Pull request description:

  The separation of extension traits into the `script_pubkey` module does not assist clarity and makes it less ergonomic for users having to import traits from different locations. 
  
  Inline and move all the logic from `address::script_pubkey` and remove the module. Excuse the code churn, this is 100% my fault.


ACKs for top commit:
  apoelstra:
    ACK 25e1d8d23d6c767f7fee00cba2bd6d263d8f93e1; successfully ran local tests


Tree-SHA512: 0796f1e8b6d4791325e31449537ee80749d

85 of 93 new or added lines in 6 files covered. (91.4%)

902 existing lines in 37 files now uncovered.

21300 of 25488 relevant lines covered (83.57%)

15300.55 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
74.31
 3.97% bitcoin/src/blockdata/script/owned.rs
6
79.15
 0.09% bitcoin/src/blockdata/script/borrowed.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
79.67
 -0.47% bitcoin/src/bip152.rs
1
46.49
 0.73% bitcoin/src/consensus/serde.rs
1
85.3
 -0.72% bitcoin/src/crypto/sighash.rs
1
81.15
 0.2% hashes/src/macros.rs
1
96.58
 -0.12% primitives/src/witness.rs
1
74.15
 -0.02% units/src/parse.rs
2
89.47
 -5.26% bitcoin/src/lib.rs
2
70.77
 -2.42% bitcoin/src/psbt/map/global.rs
2
96.55
 0.84% bitcoin/src/psbt/map/output.rs
5
47.06
 0.0% bitcoin/src/network/params.rs
8
91.8
 -0.26% primitives/src/transaction.rs
8
91.33
 -2.9% units/src/amount/serde.rs
8
98.79
 0.37% units/src/amount/tests.rs
9
86.15
 2.59% bitcoin/src/psbt/raw.rs
9
96.27
 -0.35% bitcoin/src/psbt/serialize.rs
9
85.25
 -0.69% primitives/src/sequence.rs
11
37.17
 -10.95% internals/src/serde.rs
12
93.78
 -0.41% bitcoin/src/psbt/map/input.rs
14
88.37
 -1.26% units/src/amount/unsigned.rs
16
89.97
 -0.23% units/src/amount/mod.rs
21
95.4
 -0.34% bitcoin/src/consensus/encode.rs
22
14.29
 -0.47% bitcoin/src/psbt/error.rs
22
89.45
 1.07% units/src/weight.rs
24
64.71
 1.0% units/src/locktime/absolute.rs
24
82.63
 -4.93% units/src/locktime/relative.rs
25
87.05
 -9.35% primitives/src/locktime/absolute.rs
28
83.08
 20.29% units/src/block.rs
32
79.14
 -4.84% bitcoin/src/network/mod.rs
33
89.07
 -10.25% primitives/src/locktime/relative.rs
34
81.87
 -5.33% units/src/fee_rate/mod.rs
37
23.73
 -18.79% units/src/amount/error.rs
41
63.87
 -18.33% units/src/result.rs
45
21.88
 -0.47% units/src/fee_rate/serde.rs
56
93.28
 -2.51% bitcoin/src/blockdata/transaction.rs
75
77.05
 -0.49% bitcoin/src/taproot/mod.rs
100
85.34
 0.15% bitcoin/src/bip32.rs
162
87.04
 0.66% bitcoin/src/psbt/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 16132836379.1 129
83.57
 GitHub Action Run
Source Files on build 16132836379