bitcoindevkit / bdk / 16352980005

79%

push

github

Merge bitcoindevkit/bdk#1993: keychain_txout: `apply_changeset` restores spk cache before last revealed

<a class=hub.com/bitcoindevkit/bdk/commit/6ddecc983ab3fb163303af4902bd10cf7e4a1fdf">6ddecc983 refactor(keychain_txout): `apply_changeset` restores spk cache before last revealed (valued mammal)

Pull request description:

  This patch improves readability and maintains logical consistency with the use of `spk_cache` throughout the `keychain_txout` module.

  While it might offer a performance benefit, the results are mostly comparable with the current benchmarks as far as I can tell. At least there's no indication that it would negatively impact performance.

  fixes #1975

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  LagginTimes:
    ACK 6ddecc983ab3fb163303af4902bd10cf7e4a1fdf

Tree-SHA512: 4c11d049fb5f1d9d9cbebb1510ae0e1be66

5 of 5 new or added lines in 1 file covered. (100.0%)

5324 of 6479 relevant lines covered (82.17%)

32478.87 hits per line