bitcoindevkit / bdk / 16369291445

79%

push

github

Merge bitcoindevkit/bdk#1981: refactor(electrum): remove `unwrap()`s and `expect()`s

<a class=hub.com/bitcoindevkit/bdk/commit/b24ae6d71815e268417034fda44f2d57325f6166">b24ae6d71<a href="https://github.com/bitcoindevkit/bdk/commit/e5f25a861048dd9062e1b4dbaa771e2969251542"> test(electrum): test sync with incorrect network (Wei Chen)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/0fdbe9d170941218dddd396c7204bfb8de035d43">0fdbe9d17</a><a href="https://github.com/bitcoindevkit/bdk/commit/e5f25a861048dd9062e1b4dbaa771e2969251542"> fix(electrum): Return error on incorrect network (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/2b56f1a0487742d9a5a3043c8235c3ecca96a487">2b56f1a04</a> refactor(electrum): remove `unwrap()`s and `expect()`s (Wei Chen)

Pull request description:

  Partially resolves https://github.com/bitcoindevkit/bdk_wallet/issues/30.

  ### Description

  This PR eliminates all `unwrap()` and `expect()` calls from `bdk_electrum_client`, replacing them with proper error handling. Given that all public methods already return `Result`, we now propagate error messages instead of panicking.

  ### Changelog notice

  * Removed all `unwrap()`s and `expect()`s from `bdk_electrum_client.rs`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK b24ae6d71815e268417034fda44f2d57325f6166

Tree-SHA512: 33c08031f7e7519e2e9745d0bf32e3b47cc

35 of 40 new or added lines in 1 file covered. (87.5%)

5345 of 6504 relevant lines covered (82.18%)

33463.63 hits per line