bitcoindevkit / bdk / 16188133791

78%

push

github

Merge bitcoindevkit/bdk#1976: Disallow unconfirmed coinbase

<a class=hub.com/bitcoindevkit/bdk/commit/c84035e4d804943da7b3308411a1402b1ff6e2ad">c84035e4d<a href="https://github.com/bitcoindevkit/bdk/commit/d9c2b95512608f694a177b823b163f67c3326e15"> test(chain): Add scenario: coinbase tx must not become unconfirmed (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/e8da007011c3c7e247c26a1c9984319229bb0afa">e8da00701</a> fix(chain): Unconfirmed coinbase txs should never be canonical (志宇)

Pull request description:

  ### Description

  The logic in `CanonicalIter` includes transactions anchored to blocks outside the best chain, since they may still appear in the mempool.

  However, coinbase transactions can never be unconfirmed—a case the previous logic failed to exclude.

  ### Notes to the reviewers

  Sorry for my previous oversight on this.

  ### Changelog notice

  ```md
  Fixed:
  - During canonicalization, exclude coinbase transactions when considering txs that are anchored in stale blocks.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### Bugfixes:

  ~* [ ] This pull request breaks the existing API~
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    self-ACK c84035e4d804943da7b3308411a1402b1ff6e2ad

Tree-SHA512: 3aaff032c0437f6706e5045974a7528046b

3 of 4 new or added lines in 1 file covered. (75.0%)

5324 of 6479 relevant lines covered (82.17%)

32830.44 hits per line