rust-bitcoin / rust-bitcoin / 16352614033

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4698: Remove amount serde traits

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/37eb78b809737647ec53dca1ce0b2a3423627bf6">37eb78b80 Remove amount serde traits (Tobin C. Harding)

Pull request description:

  Now that a `SignedAmount` can be infallibly converted to an `Amount` we do not need all the internal complexity in the `amount::serde` module, we can just de/serialize `SignedAmount` and convert it to `Amount`. This also has the advantage if someone has a type that is `Into<SignedAmount>` and `TryFrom<SignedAmount>` they can de/serialize it also - BOOM!
  
  Props to Kix for the idea.
  
  Close: #4674


ACKs for top commit:
  apoelstra:
    ACK 37eb78b809737647ec53dca1ce0b2a3423627bf6; successfully ran local tests


Tree-SHA512: aadfda1580424eeb2937dbf5b170de48206

Coverage Stats

77 of 78 new or added lines in 1 file covered. (98.72%)

2 existing lines in 2 files now uncovered.

21365 of 25564 relevant lines covered (83.57%)

15237.36 hits per line