rust-bitcoin / rust-bitcoin / 16353401521

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4662: primitives: Inline `impl_to_hex_from_lower_hex` macro and deprecate

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d42d478f1b6aab9969bb73108d8afdaf3db975e3">d42d478f1 primitives: Inline impl_to_hex_from_lower_hex and deprecate (Tobin C. Harding)

Pull request description:

  Macros are basically just a pain in the arse. This one is used to reduced code duplication/verbosity even thought the function can be written as a one-liner.
  
  Also calling macros across crate boundries is error prone and a constant source of maintenance grief.
  
  Note also:
  
  - The generated docs are quite general
  - `#[inline]` is missing
  - The docs on the macro are wrong in regards to the no-op
  
  Remove all calls to the macro from `primitives` and inline using terse syntax by way of the `format!` macro.
  
  Add `deprecated` attribute and direct users to just use `format!("{var:x}")` instead.


ACKs for top commit:
  apoelstra:
    ACK d42d478f1b6aab9969bb73108d8afdaf3db975e3; successfully ran local tests


Tree-SHA512: 2029bb18d3e26439e10fb50af3eec71b10e

Coverage Stats

2 of 6 new or added lines in 5 files covered. (33.33%)

11 existing lines in 2 files now uncovered.

21352 of 25560 relevant lines covered (83.54%)

15213.26 hits per line