rust-bitcoin / rust-bitcoin / 16327459817

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4563: Add `Coinbase(Transaction)` newtype to distinguish coinbase transactions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/394fa537508674388f2cd4cdb23eccbc51d599ae">394fa5375<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2bb9bb6bc99ba07ed3d543a512ec3d2a9462770d"> Add comprehensive tests for Coinbase type and block validation (jrakibi)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0edabd471fd7993bb94df0554497600022cc8ad2">0edabd471</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2bb9bb6bc99ba07ed3d543a512ec3d2a9462770d"> Add coinbase validation to Block::validate() with new error variants (jrakibi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ca4d87dd4a028c40b62a054fbb67d8f5d721262e">ca4d87dd4</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2bb9bb6bc99ba07ed3d543a512ec3d2a9462770d"> Change Block::coinbase() to return &amp;Coinbase instead of Option&lt;&amp;Transaction&gt; (jrakibi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7c438b277e4eec61d40d66bd760428976bafd7cd">7c438b277</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2bb9bb6bc99ba07ed3d543a512ec3d2a9462770d"> transaction: Implement Coinbase type with explicit API design (jrakibi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6571307317bc936f29e5a218026446374eb5a01c">657130731</a> transaction: Add Coinbase newtype to distinguish coinbase transactions (jrakibi)

Pull request description:

  Coinbase transactions are structurally and semantically different from normal transactions.
  
  We introduce a distinct `Coinbase(Transaction)` newtype to make this distinction explicit at the type level, helping to catch logic that shouldn't apply to coinbases (e.g attempting to look up coinbase inputs in the UTXO set).
  
  This PR is split into several patches to keep changes reviewable and to document the rationale behind each step.
  
  - Closes #4437 
  - Closes #4543


ACKs for top commit:
  tcharding:
    ACK 394fa537508674388f2cd4cdb23eccbc51d599ae
  apoelstra:
    ACK 394fa537508674388f2cd4cdb23eccbc51d599ae; successfully ran local tests


Tree-SHA512: 3e7bc95e3d44f56c946119dbb3cceb0d432

116 of 123 new or added lines in 2 files covered. (94.31%)

21395 of 25598 relevant lines covered (83.58%)

15250.82 hits per line