agama-project / agama / 16342134848

74%

push

github

fix: better handling of missing license translations (#2571)

## Problem

* [bsc#1238364](https://bugzilla.suse.com/show_bug.cgi?id=1238364)

When displaying a product license, Agama allows to select the language
to display the license. In general, it offers the same list of languages
Agama is translated to. This has a few problems:

* In some cases, the license is no translated to that language. The
Agama falls back to English without informing the user.
* It is just another language selector, which is kind of confusing.

## Solution

Now the license is directly shown in the same language that Agama is
using. No additional language selector. If the translation is missing:

* It tries to find an alternative language (e.g., "Spanish" for
"Catalan".
* If there is no alternative, it falls back to English.

## Alternative language

To search for an alternative language, Agama choses the first language
in the same "territory". For instance, if you pick "Catalan" ("ca-ES"),
Agama uses the [langtable data](https://pypi.org/project/langtable/) to
search for the first language in the same territory, which in this case
it is "Spanish" (es).

## Testing

- Added a new unit test
- Tested manually

## Screenshots

<details>
<summary>The license is translated. No warning and no
selector.</summary>

<img width="1335" height="1009" alt="license-found-license"
src="https://github.com/user-attachments/assets/795ef340-cc38-4cf9-9841-3151c76f8b94"
/>
</details>

<details>
<summary>The license is not translated to Catalan, but to Spanish. Warn
the user.</summary>

<img width="1335" height="1009" alt="license-missing-translation"
src="https://github.com/user-attachments/assets/7bfbbd81-a05f-45d0-baaa-52f03cce856b"
/>
</details>

<details>
<summary>Fall back to English. Warn the user.</summary>

<img width="1335" height="1009" alt="license-fallback-english"
src="https://github.com/user-attachments/assets/8dcc931f-1ba3-4020-b3fa-c4f261221d9c"
/>
</details>

## Known problems... (continued)

2131 of 3860 branches covered (55.21%)

Branch coverage included in aggregate %.

46 of 49 new or added lines in 2 files covered. (93.88%)

24657 of 37790 relevant lines covered (65.25%)

49.01 hits per line