agama-project / agama / 16344430191

74%

Build Type

push

github

Committed by web-flow

Commit Message

initial attempt to ensure that product is properly selected when needed (#2570)

## Problem

It is possible to not specify product in agama profile and it can lead
to crash in ruby code or unexpected results.

bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1246601


## Solution

For parts that needs product to be already selected add check and report
error if it is not the case.


## Testing

- *Tested manually*


## Screenshots

output before:

```shell
agama2:~ # agama config load < profile.jsonnet 
✓ The profile is valid.

Error processing storage settings: Backend call failed with status 400 and text '{"error":"Agama service error: D-Bus service error: org.freedesktop.DBus.Error.Failed: undefined method 'reject' for nil; caused by 1 sender=:1.1 -> dest=org.opensuse.Agama.Storage1 serial=219 reply_serial= path=/org/opensuse/Agama/Storage1; interface=org.opensuse.Agama.Storage1; member=Reprobe error_name="}'

Caused by:
    Backend call failed with status 400 and text '{"error":"Agama service error: D-Bus service error: org.freedesktop.DBus.Error.Failed: undefined method 'reject' for nil; caused by 1 sender=:1.1 -> dest=org.opensuse.Agama.Storage1 serial=219 reply_serial= path=/org/opensuse/Agama/Storage1; interface=org.opensuse.Agama.Storage1; member=Reprobe error_name="}'
```

and output with fix:

```shell
agama2:~ # agama config load < profile.jsonnet 
✓ The profile is valid.

Cannot proceed with profile without specified product
```

Run Details

2131 of 3860 branches covered (55.21%)

Branch coverage included in aggregate %.

0 of 30 new or added lines in 1 file covered. (0.0%)

24 existing lines in 2 files now uncovered.

22698 of 28794 relevant lines covered (78.83%)

64.27 hits per line