shinghim / rust-bitcoin / 16132836379

push

github

Merge rust-bitcoin/rust-bitcoin#4668: Inline `script_pubkey` extension traits

<a class=hub.com/shinghim/rust-bitcoin/commit/25e1d8d23d6c767f7fee00cba2bd6d263d8f93e1">25e1d8d23<a href="https://github.com/shinghim/rust-bitcoin/commit/f7274a57c36d0b8d8cc528426e269c27d496bd5f"> Inline script_pubkey ScriptBuf extension trait (Tobin C. Harding)
<a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/afd36079e559f4222dd6f56b27fc25c0976eb54f">afd36079e</a><a href="https://github.com/shinghim/rust-bitcoin/commit/f7274a57c36d0b8d8cc528426e269c27d496bd5f"> Inline script_pubkey Script extension traits (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/f8823f5c6a596238ff5f7fa30610737291fe0e5e">f8823f5c6</a> Remove BuilderExt trait (Tobin C. Harding)

Pull request description:

  The separation of extension traits into the `script_pubkey` module does not assist clarity and makes it less ergonomic for users having to import traits from different locations. 
  
  Inline and move all the logic from `address::script_pubkey` and remove the module. Excuse the code churn, this is 100% my fault.


ACKs for top commit:
  apoelstra:
    ACK 25e1d8d23d6c767f7fee00cba2bd6d263d8f93e1; successfully ran local tests


Tree-SHA512: 0796f1e8b6d4791325e31449537ee80749d

85 of 93 new or added lines in 6 files covered. (91.4%)

21300 of 25488 relevant lines covered (83.57%)

15300.55 hits per line