skeema / skeema / 16030228976

92%

push

github

docker: allow use of tmpfs for Percona and old MySQL 8 ARM images

This commit expands the ability to use tmpfs mounts in ephemeral database
containers, to now be permitted for all Dockerhub images used by Skeema.

Background:

For an ephemeral database, using a tmpfs mount for /var/lib/mysql (database
data directory) improves performance and eliminates SSD wear. When using
workspace=docker, Skeema v1 uses a tmpfs mount for Dockerized database
instances whenever docker-cleanup=destroy is configured. In Skeema v2, this
is planned to change to a separate option, which will be enabled by default.
Skeema's integration test database containers also use tmpfs mounts.

However, previously tmpfs was only used for "mysql:..." and "mariadb:..."
images, since Percona images encountered various fatal errors when attempting
to use a tmpfs mount.

Changes in this commit:

This commit solves the tmpfs problems with Percona images by making the tmpfs
directory be owned by the uid for the mysql user, which also notably differs
between "percona" and "percona/percona-server" images. (Skeema uses the former
for 5.x and the latter for 8.x.)

For MySQL 8.0.12-8.0.28 on ARM, tmpfs was also excluded previously but is now
permitted. On ARM, these older releases use "mysql/mysql-server" due to lack
of corresponding ARM builds for the top-level "mysql" images which we usually
prefer.

Finally, this commit fixes an integration test problem recently introduced in
ac6e8db which only came up when using non-ephemeral test containers or the
non-default env setting SKEEMA_TEST_CLEANUP=none. This is less likely to be
triggered now that all tests use tmpfs, but is fixed for sake of completeness.

6 of 9 new or added lines in 1 file covered. (66.67%)

10594 of 11370 relevant lines covered (93.18%)

1.11 hits per line