skeema / skeema / 15985787422

92%

Build Type

push

github

Committed by evanelias

Commit Message

workspaces: log performance timing with --debug

Whenever Skeema's debug option is enabled, workspace performance data will now
be logged, including timing of each stage of the workspace execution. This
information can be helpful for tuning workspace configuration options.

When using the default of workspace=temp-schema, the round-trip network
latency to the server is also shown, since this has a large effect on
workspace performance.

Several internal refactors are also present; of particular note:

* Server variable introspection no longer uses sqlx struct-scanning. (Other
  queries will likely be moved off of sqlx over time, so that the dependency
  can eventually be removed.)

* Configuration-related functions from internal/workspace/workspace.go have
  been moved into a new config.go file; ditto for tests into config_test.go.

* Some logic relating to Percona Server image tagging has been cleaned up for
  readability. Additionally, outdated code relating to ARM image point release
  selection was removed; this is no longer needed after 666ac05 but was left
  in place by mistake.

Run Details

187 of 195 new or added lines in 10 files covered. (95.9%)

1 existing line in 1 file now uncovered.

10594 of 11367 relevant lines covered (93.2%)

1.11 hits per line