skeema / skeema / 15914485413

92%

push

github

connect-options: updates for deprecations and latest driver fields

This commit makes several small tweaks to the connect-options option:

* Setting the "tls" driver field in connect-options now emits a deprecation
  warning; this will no longer be permitted in Skeema v2. Setting this field
  in connect-options has been deprecated since Skeema v1.6.0, when the
  dedicated ssl-mode option was introduced as a better alternative.

* If the "connectionAttributes" driver field is set in connect-options, it
  will now be stripped properly from the {CONNOPTS} placeholder variable in
  alter-wrapper or ddl-wrapper. Previously, this combination would cause an
  error when using e.g. `pt-online-schema-change --set-vars {CONNOPTS} ...`
  since connectionAttributes would erroneously be passed through.

* Setting the new "compress" driver field in connect-options is now prevented.
  Compression is only useful in specific places (e.g. large seed data INSERTs)
  where it will be enabled automatically in upcoming commits.

* Setting the recent "timeTruncate" driver field is now prevented. This had no
  known effect on any of Skeema's queries. If it is ever needed in the future,
  it will be set appropriately in the relevant connection pools only.

10 of 12 new or added lines in 2 files covered. (83.33%)

10531 of 11301 relevant lines covered (93.19%)

1.11 hits per line