agama-project / agama / 15924451712

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat: warn the user when using a weak password (#2513)

## Problem

Agama's web user interface does not warn the user when using a weak
password (e.g., "12", "12345678", "secret", etc.).

- [bsc#1237480](https://bugzilla.suse.com/show_bug.cgi?id=1237480)

## Solution

Agama will not prevent the user about doing that. After all, the
unattended mode writes just the password included in the profile.
However, it will warn the user in those cases.

This feature is based on `libpwquality`, which checks several aspects
related to the password strength. In the future, we might introduce a
visual indicator of the strenght or try to display all the rules, but
this one looks like a good enough first step.

## Testing

- [x] Added a new unit test
- [x] Tested manually

## Screenshots

*If the fix affects the UI attach some screenshots here.*

Run Details

1861 of 3413 branches covered (54.53%)

Branch coverage included in aggregate %.

5 of 30 new or added lines in 6 files covered. (16.67%)

19 existing lines in 3 files now uncovered.

23646 of 36292 relevant lines covered (65.15%)

46.92 hits per line