agama-project / agama / 15632199897

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat: allow registration with RMT without a code (#2469)

## Problem

The RMT can be configured to not require registration key. So sending
empty one should be valid option, but it is not possible with current
agama.

## Solution

Change registration API to distinguish between registered and
registration key, that can be empty ( used in past as indication of not
registered system ).


## Testing

- *Added a new unit test*
- *Tested manually*

Manually tested using iso from
https://download.opensuse.org/repositories/systemsmanagement:/Agama:/branches:/rmt_registration/images/iso/
IT is based on opensuse, so I install from console `agama-products-sles`
and restart agama. After then I try register against SCC to get failure
that I have to provide registration key.
Then I do from console `agama config load < reg_server.json` where
content of file is ( RMT is internal only, so require VPN )
```json
{
  "product": {
    "id": "SLES",
    "registrationUrl": "https://migration-rmt2.qe.nue2.suse.org"
  }
}
```
and then registration works and installation passes.

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

10 of 12 new or added lines in 3 files covered. (83.33%)

43 existing lines in 3 files now uncovered.

11235 of 18013 relevant lines covered (62.37%)

41.84 hits per line