bitcoindevkit / bdk_wallet / 15307316172

85%

push

github

Merge bitcoindevkit/bdk_wallet#201: Bring back TxDetails

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/6aef191f7e70980ee5df5dc34c950abc3ba111d1">6aef191f7 feat: add Wallet::tx_details method (thunderbiscuit)

Pull request description:

  Fixes #100.

  The `TxDetails` feature was put aside to focus on the 1.0 release, but now that we're done with that I want to revive the idea.

  This is very much WIP. I'm trying to figure out exactly what we want in this data structure, and I'm not even sure my way to get at the data is the most efficient way to do it.

  ### Notes to the reviewers

  ### Changelog notice

  ```md
  Added:
      - Wallet::get_tx_details method [#201]

  [#201]: https://github.com/bitcoindevkit/bdk_wallet/pull/201
  ```

  ### Checklists

  #### All Submissions:

  * [ ] I've signed all my commits
  * [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [ ] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 6aef191f7e70980ee5df5dc34c950abc3ba111d1

Tree-SHA512: ae6d50927d3efc4f69f1ff8ae824f165984

21 of 21 new or added lines in 1 file covered. (100.0%)

7340 of 8591 relevant lines covered (85.44%)

3458.44 hits per line