bitcoindevkit / bdk_wallet / 15304985468

85%

push

github

Merge bitcoindevkit/bdk_wallet#232: fix: Validate prevouts in `get_psbt_input`

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/6ffc87421c89868465fa538bc2c0b9c307730b79">6ffc87421<a href="https://github.com/bitcoindevkit/bdk_wallet/commit/f0840c0344fd0690c73c2360bb10781ea16c97c9"> fix!: Check prevout bounds in `Wallet::build_fee_bump` (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/00a57cfee4e85451f123dc2cb9d3182b13e31ed9">00a57cfee</a> fix: Validate prevouts in `get_psbt_input` (ItshMoh)

Pull request description:

  Fixes #50
  Fixes #51
  Replaces bitcoindevkit/bdk#1911
  Replaces bitcoindevkit/bdk#1913

  ### Description

  We should check the bounds of the prev txs.

  ### Changelog notice

  ```md
  Fixed:
      - Wallet::get_psbt_input method now checks bounds when fetching prevout
      - Wallet::build_fee_bump method now checks bounds when fetching prevout
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  ~~* [ ] I've added tests to reproduce the issue which are now passing~~
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 6ffc87421c89868465fa538bc2c0b9c307730b79

Tree-SHA512: f2df49b5b321cc3050122d19eef71bd3752

15 of 19 new or added lines in 2 files covered. (78.95%)

7319 of 8570 relevant lines covered (85.4%)

3465.87 hits per line