bitcoindevkit / bdk_wallet / 15307638617

85%

push

github

Merge bitcoindevkit/bdk_wallet#247: deps: Update `bdk_chain` to 0.23.0

6aba330e7 fix: gracefully handle `reveal_to_target` (valued mammal)
741f2aeb6 test: persist indexed script pubkeys (valued mammal)
db255555e deps!: Update `bdk_chain` to 0.23.0 (valued mammal)

Pull request description:

  ### Description

  The PR updates bdk_chain to 0.23.0. Additionally we introduce the ability to persist derived SPKs indexed by descriptor ID and derivation index.

  The `CreateParams::use_spk_cache` method enables or disables a persistent cache for script pubkeys (SPKs) derived by the wallet. When enabled, the wallet will store and reuse previously derived SPKs, avoiding redundant derivation on subsequent loads.

  When a wallet has many revealed addresses (i.e., many derived SPKs), loading the wallet can become slow if every address must be re-derived from scratch.

  By enabling the SPK cache:

  - **On wallet creation:** The wallet will persistently store each derived SPK as addresses are revealed.
  - **On wallet load:** If `use_spk_cache` is also set in the corresponding `LoadParams`, the wallet will load the cached SPKs directly from storage, skipping the need to re-derive them from the descriptor. This can dramatically reduce load times for wallets with hundreds or thousands of revealed addresses, as the expensive crypto operations are avoided.

  **Caveat:**
  Both creation and loading must have `use_spk_cache(true)` set for the cache to be used. If not, the wallet will fall back to deriving SPKs as usual.

  fixes #246
  fixes #237

  ### Changelog notice

  #### Added

  - `CreateParams::use_spk_cache`
  - `LoadParams::use_spk_cache`

  #### Changed

  - bump bdk_chain to 0.23.0
  - **Note:** This change extends the wallet `ChangeSet` type by adding `first_seen` to the tx_graph member, and adding `spk_cache` to the indexer.

  ### Checklists

  #### All Submi... (continued)

49 of 49 new or added lines in 4 files covered. (100.0%)

7377 of 8623 relevant lines covered (85.55%)

3484.14 hits per line