bitcoindevkit / bdk_wallet / 15304626099

85%

push

github

Merge bitcoindevkit/bdk_wallet#241: fix(wallet): fix `into_descriptor_key` for DescriptorPublicKey

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/469cfd03cb1461c23ebb22f84eb850ea8a9b24db">469cfd03c fix(wallet): fix `into_descriptor_key` for DescriptorPublicKey (valued mammal)

Pull request description:

  Fix `into_descriptor_key` for `DescriptorPublicKey` by including the missing match arm for `DescriptorPublicKey::MultiXPub` when initializing `networks`.

  Test that `into_wallet_descriptor` correctly parses a multipath descriptor and fails if passed a network that is invalid for the descriptor.

  Note that rust-miniscript doesn't support parsing a multipath descriptor containing extended private keys.

  fixes #10

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 469cfd03cb1461c23ebb22f84eb850ea8a9b24db
  oleonardolima:
    ACK 469cfd03cb1461c23ebb22f84eb850ea8a9b24db

Tree-SHA512: e5b26b5e5fc9aab93ba560f384db3667fe4

39 of 39 new or added lines in 2 files covered. (100.0%)

7312 of 8561 relevant lines covered (85.41%)

3468.96 hits per line