kobotoolbox / kpi / 15303188704

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(massEmails): enable recurring sends TASK-1693 (#5796)

### 📣 Summary
Turn on new process for recurring mass emails.



### 📖 Description
Allows the creation of regularly recurring emails for certain
conditions. Instead of just creating email configs and sending them the
next day with 'Add to daily send,' superusers specify a frequency for
how often a given individual should receive the email. One time sends
are still possible with a frequency of -1. Once a recurring email is
added to the daily send, beginning the next day, users matching the
query will be calculated every day and emails sent, filtering out those
who received the same email too recently.


### 💭 Notes
This PR does a lot of things at once, by necessity. 
1. Show 'frequency' and 'live' fields in admin
2. Update 'Add to daily send' to just toggle the 'live' field, doing
some additional checking to make sure we are not re-sending a one-time
send
3. Enables the new email send process, where one job calculates all the
users who will receive emails and the other actually sends them
4. Fix a bug where the process that actually sends emails would not run
if there were emails that were live but had no recipients that day
5. Update `generate_mass_email_user_lists` to make use of
`MASS_EMAILS_CONDENSE_SEND` for easier testing
6. Schedule the task that sends the emails to start a minute after the
task that enqueues them, otherwise the first run will always exit early
because no records will have been enqueued by then



### 👀 Preview steps
Use mailhog or file-backed email send for easier testing.

1. ℹ️ have at least superuser account (other accounts may be useful as
well)
7. Make sure MASS_EMAILS_CONDENSE_SEND is True
8. In admin, add user emails to Constance > Config >
MASS_EMAIL_TEST_EMAILS
9. Create 3 new MassEmailConfigs, with the 'test_users' query and
frequencies of -1, 1, and 2. Don't check 'live'
10. Add all configs to the daily send
11. 🟢 All 3 MassEmailConfigs should now show as liv... (continued)

Run Details

6265 of 9927 branches covered (63.11%)

34 of 38 new or added lines in 4 files covered. (89.47%)

1 existing line in 1 file now uncovered.

23896 of 29475 relevant lines covered (81.07%)

1.6 hits per line