kobotoolbox / kpi / 15281393857

81%

master: 76%

push

github

fix(billing): fix missing interval dropdown for "File Storage" add-on in some languages DEV-261 (#5797)



### 📣 Summary
<!-- Delete this section if changes are internal only. -->
<!-- One sentence summary for the public changelog, worded for
non-technical seasoned Kobo users. -->

Fixes the issue where if Kobo is in some non-english languages, the time
interval dropdown for choosing month/year doesn't appear.

### 💭 Notes
<!-- Delete this section if empty. -->
<!-- Anything else useful that's not said above,worded for
reviewers, testers, and future git archaeologist collegues. Examples:
- screenshots, copy-pasted logs, etc.
- what was tried but didn't work,
- conscious short-term vs long-term tradeoffs,
- proactively answer likely questions,
-->

Not sure why we had a hard-coded string check for this when a boolean
prop would be language agnostic. See
https://linear.app/kobotoolbox/issue/DEV-261/add-ons-working-differently-in-languages-other-than-en#comment-cdbd29f7
for a more detailed debugging log

### ⚠️ **There is a different version of this bug present on
`eu.kobotoolbox.org` that may not be fixed with this code. See
[debugging
log](https://linear.app/kobotoolbox/issue/DEV-261/add-ons-working-differently-in-languages-other-than-en#comment-cdbd29f7)**

### 👀 Preview steps
<!-- Delete this section if behavior can't change. -->
<!-- If behavior changes or merely may change, add a preview of a
minimal happy path. -->

Bug template:
1. ℹ️ have an account and a project
2. have stripe enabled
3. go to account settings -> add-ons
4. switch the language to anything except: English, မြန်မာဘာသာ, Magyr,
Khmer, كوردی, Lingala, Nyanja, नेपाली, Kiswahili, and Yoruba
5. 🔴 [on main] notice that the "month/year" dropdown is missing in the
"File Storage" row
6. 🟢 [on PR] notice that the dropdown is present for every language

6257 of 9917 branches covered (63.09%)

23882 of 29461 relevant lines covered (81.06%)

1.6 hits per line