agama-project / agama / 15250036485

73%

push

github

Consider bootable RAIDs when resolving an omitted boot device (#2388)

This pull request adapts Agama to some historical behavior of YaST, but
(hopefully) in a more structured and explicit way.

## Historical background

YaST considers some software RAIDs to be bootable and, thus, it:
  - offers them as an option in the Guided Setup
  - considers them as candidates for the initial proposal

The criteria used by YaST is kind of arbitrary, based on some heuristic
imposed by SUSE partners and refined over time. See [this
explanation](https://github.com/yast/yast-storage-ng/blob/db1febb34/src/lib/y2storage/disk_analyzer.rb#L131).

To not break the existing use cases, we should keep the ability in Agama
to install on those RAIDs. That’s relevant for:
  1. The initial proposal
  2. The web UI
3. The selection of the implicit boot device (when is omitted in the
configuration)

But we also need the option to manipulate other RAID devices that are
not considered to be candidates for a normal installation (ie.
bootable). For example, to be able to select them at the web UI with any
purpose.

## Implementation

This pull request:
- Sets the basis for all scenarios by providing a clear way to
distinguish different types of RAIDs (and drives).
- Improves the situation at 3 (ie. when resolving the omitted boot
device)

To address the first goal, `System` now offers four methods
`available_drives`, `candidate_drives`, `available_md_raids` and
`candidate_md_raids`. Check the documentation for the exact meaning.

To address the latter goal, this introduces the ability to automatically
determine the boot device if the storage configuration omits
`boot.device` but specifies the root partition must be located at a
bootable (candidate) RAID.

## Dependencies

This PR depends on https://github.com/yast/yast-storage-ng/pull/1411

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

35 of 35 new or added lines in 5 files covered. (100.0%)

11068 of 17618 relevant lines covered (62.82%)

40.18 hits per line