• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Neptune-Crypto / neptune-core / 15023035928
75%

Build:
DEFAULT BRANCH: master
Ran 14 May 2025 02:43PM UTC
Jobs 1
Files 208
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 May 2025 02:13PM UTC coverage: 71.708% (+0.05%) from 71.658%
15023035928

push

github

dan-da
fix: validate TransactionDetails

This change ensures that TransactionDetails are validated
when GlobalStateLock::record_transaction() is called and can catch validation
errors for mock-proof using networks that otherwise might slip through.

It is not strictly necessary to validate TransactionDetails when the network
uses real proofs because a valid proof indicates the Tx is valid and also the
TransactionDetails, so long as it matches the Tx.

However:
 1. A network that uses mock proofs should validate the TransactionDetails
because a "valid" mock-proof can be obtained with invalid TransactionDetails.

 2. The enum error returned from TransactionDetails provides more insight into
what is wrong than the boolean value from Transaction::verify_proof()

 3. It is preferable to use the same logic whether the network uses mock proofs
or not.

For these reasons, TxCreationArtifacts::verify() now validates the
TransactionDetails.

4 of 4 new or added lines in 2 files covered. (100.0%)

191 existing lines in 6 files now uncovered.

19967 of 27845 relevant lines covered (71.71%)

383435.9 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
99.39
5.8% src/models/state/transaction_details.rs
2
71.7
-0.48% src/models/peer.rs
3
72.53
-3.3% src/api/regtest/regtest_impl.rs
9
96.1
-2.92% src/models/blockchain/type_scripts/time_lock.rs
66
75.41
-0.12% src/mine_loop.rs
110
81.88
0.06% src/models/state/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 15023035928.1 14 May 2025 02:43PM UTC 208
71.71
GitHub Action Run
Source Files on build 15023035928
  • Tree
  • List 208
  • Changed 12
  • Source Changed 5
  • Coverage Changed 12
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #15023035928
  • 6bbe15a5 on github
  • Prev Build on master (#15004177269)
  • Next Build on master (#15023798664)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc