Neptune-Crypto / neptune-core / 15023798664

75%

Build Type

push

github

Committed by Sword-Smith

Commit Message

privacy(mine_loop): Never add zero-valued composer outputs

If composer chooses to reward the entire block subsidy to the guesser,
there is no need for the composer to add any outputs to the coinbase
transaction.

Prior to this commit, the composer would in that scenario add two ouputs
to the coinbase transaction. Many such blocks with two zero-valued outputs
exist on main net today, so this is not a hypothetical scenario.

Avoiding these zero-valued outputs in the coinbase has two benefits:
 - It leaves more room for other transactions to be merged into the
   block.
 - It avoids zero-valued leafs in the AOCL whose presence would otherwise
   reduce the anonymity set as zero valued leafs are less likely to be
   spent than any other leafs and can, in the case of an empty block, be
   identified in the AOCL.

Run Details

15 of 15 new or added lines in 3 files covered. (100.0%)

7 existing lines in 3 files now uncovered.

19970 of 27835 relevant lines covered (71.74%)

382130.58 hits per line